Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Extra Enhancement #375

Closed
wants to merge 2 commits into from
Closed

CSS Extra Enhancement #375

wants to merge 2 commits into from

Conversation

CupOfTea696
Copy link
Contributor

Added string & punctuation to css.selector.inside

@LeaVerou
Copy link
Member

Thanks! Any screenshot/demo? Also, the indentation seems off, please verify that you’re using tabs.

@CupOfTea696
Copy link
Contributor Author

You can see a live demo here.
I hadn't noticed the indentation, I'll fix that.

@LeaVerou
Copy link
Member

What’s the point of highlighting selectors e.g. green if parts of them are going to have other colors though? Perhaps it would be better if it was shades of the original token color, e.g. lighter/darker green?
What do others think?

@CupOfTea696
Copy link
Contributor Author

Well that's just the css, I didn't edit anything about that I just added the definitions.

@mAAdhaTTah
Copy link
Member

I don't think is needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants