Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 1.16.0 #1833

Merged
merged 2 commits into from
Mar 24, 2019
Merged

Add changelog for 1.16.0 #1833

merged 2 commits into from
Mar 24, 2019

Conversation

mAAdhaTTah
Copy link
Member

This is WIP, as I'll be fixing it as new PRs come in. There are a few I want to land before we release, but this gets it started so we can finally get a release out.

Also modified the changelog generation, as I'd like to try and automate as much of this as possible, so we can get releases out more frequently than we have been.

@mAAdhaTTah mAAdhaTTah added this to the 1.16.0 milestone Mar 24, 2019
@mAAdhaTTah
Copy link
Member Author

2 notes:

  1. Created a milestone for 1.16.0 for the last few things I'd like to land before we release.
  2. I'm going to rebase these commits after I'm done, but I'll be pushing incrementally.

@RunDevelopment
Copy link
Member

I wasn't aware of this before, but we should also adjust the .npmignore file because of #1781.

@mAAdhaTTah mAAdhaTTah force-pushed the add-changelog-for-1.16.0 branch from 48be31a to 8b06645 Compare March 24, 2019 22:05
This forms the basis of the CHANGELOG, but the commits
need to be formatted with the linkify command and sorted
into the various sections.
@mAAdhaTTah mAAdhaTTah force-pushed the add-changelog-for-1.16.0 branch from 8b06645 to 4bdec34 Compare March 24, 2019 22:10
@mAAdhaTTah
Copy link
Member Author

Rebased & ready for review.

@RunDevelopment
Copy link
Member

Unrelated: I know what the first thing I will do after we publish 1.16.0.

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I think the changelog is good as is but the bold header-like entries should be sorted IMO.

@mAAdhaTTah mAAdhaTTah force-pushed the add-changelog-for-1.16.0 branch from 4bdec34 to d455c43 Compare March 24, 2019 22:33
@mAAdhaTTah
Copy link
Member Author

Good call. While sorting, I also realized I had Java twice. I also love that we have both Markup & Markdown as languages 😆.

CHANGELOG.md Outdated Show resolved Hide resolved
@mAAdhaTTah mAAdhaTTah force-pushed the add-changelog-for-1.16.0 branch from d455c43 to 6f8a397 Compare March 24, 2019 22:42
@mAAdhaTTah mAAdhaTTah force-pushed the add-changelog-for-1.16.0 branch from 6f8a397 to af95284 Compare March 24, 2019 22:45
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mAAdhaTTah mAAdhaTTah force-pushed the add-changelog-for-1.16.0 branch from af95284 to d101589 Compare March 24, 2019 22:55
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mAAdhaTTah mAAdhaTTah merged commit 695dddc into master Mar 24, 2019
@mAAdhaTTah mAAdhaTTah deleted the add-changelog-for-1.16.0 branch March 24, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants