Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rel="icon" instead of rel="shortcut icon" #1391

Closed
wants to merge 2 commits into from
Closed

Use rel="icon" instead of rel="shortcut icon" #1391

wants to merge 2 commits into from

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Apr 14, 2018

<link rel="shortcut icon" is deprecated and <link rel="icon" should be used.

(Also, remove unneeded (?!\*) from the lang regex in prism-file-highlight.js.)

valtlai added 2 commits April 14, 2018 04:10
Also, remove unneeded `(?!\*)` from the `lang` regex in `prism-file-highlight.js.`
npm tests passed
@Golmote
Copy link
Contributor

Golmote commented Apr 16, 2018

Hi! Thanks for contributing again.
But please don't include both changes in a single PR, instead make two PRs, one for each issue.

@valtlai valtlai closed this Apr 18, 2018
@valtlai valtlai deleted the rel-icon branch April 18, 2018 19:21
@valtlai
Copy link
Contributor Author

valtlai commented Apr 18, 2018

New PRs: #1398 and #1399.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants