Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coy theme: height CSS tag creates design issues. #1223

Closed
FlipperPA opened this issue Nov 17, 2017 · 1 comment
Closed

Coy theme: height CSS tag creates design issues. #1223

FlipperPA opened this issue Nov 17, 2017 · 1 comment

Comments

@FlipperPA
Copy link
Contributor

The height=100% CSS tag in the coy theme - which doesn't seem to exist in other theme CSS definitions - is causing the code block to render as the browser's height:

Broken:

image

Fixed:

image

Since it is such a minor change, I will propose a code change via GitHub to remove this single line from the Coy theme. Thanks for your efforts, they are widely appreciated!
FlipperPA added a commit to FlipperPA/prism that referenced this issue Nov 17, 2017
@FlipperPA
The 'height' element makes code blocks the height of the browser canvas.
4e83cd6 
Removing the height element - which does not seem to be in other themes - fixes this issue. See PrismJS#1223 for details and screenshots. Thanks!
@FlipperPA FlipperPA mentioned this issue Nov 17, 2017
Merged
@Golmote
Copy link
Contributor

Golmote commented Dec 5, 2017

I'm not sure what it was for... But I couldn't find any explicit browser issue without the height property, so I guess it's ok to remove it. Thanks!

@Golmote Golmote closed this as completed Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FlipperPA @Golmote