[LIBSTELL] Use a more direct (i.e. no loops) implementation of mpi_calc_myrange
#244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a further iteration of #240.
I agree and therefore, I would say that it would be valuable to have this routine very well documented and almost obvious to understand.
In the suggested change, the assumptions and the approach are (I hope) quite explicitly documented and reasoned about. Please let me know if you think differently about this.
I also attached a stand-alone test program (
test_mpi_calc_myrange
) now that I used to verify that the computedmystart
andmyend
are identical (for the probed parameter value ranges) to what the old implementation produced:test_mpi_calc_myrange.zip
It is compiled with
gfortran test_mpi_calc_myrange.f -o test_mpi_calc_myrange
and then run with
./test_mpi_calc_myrange
and should then printall tests passed successfully
.I understand that it was not obvious from the previous iteration of this PR that the outputs are identical. Sorry for that.