Bugfix/debug fixes #218
Merged
Bugfix/debug fixes #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kudav
reviewed
Jan 17, 2024
There was a problem hiding this comment.
When trying to run a simulation, I get an error on line 351 of beams3d_physics mod (floating point invalid operation). I addressed a similar issue in fdfde23 by enforcing s>=0 in the orbit following, but not sure if this is what we want.
kudav
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These bugfixes essentially fix issues associated with runtime errors when compiling with the Intel compilers. The fixes are mostly related to BEASM3D but will proably propagate to FIELDLINES and STELLOPT. Essentially these fixes help patch runtime errors which Intel throws when
-check allis used. Most of the errors had to do with divide by zero type issues where the result of the divide by zero was throw away anyway. There is a change in wall_mod which could slow down the generation of accelerated walls but otherwise most of the fixes speed up the code if anything. A bug inbeams3d_diagnostic.f90related to usingREALinstead ofREAL(rprec)was also addressed. This should close #193.