Allow multiple receivers in an element. #425
Conversation
There was a problem hiding this comment.
Can you add station
S0006 AA 2500.0000000 2500.0000000 0.0 0.0
to the stations file in tests/unit-tests/displacement_tests/Newmark/serial/test1? To amke sure that this code path gets tested. S0011 is the same receiver as S0006, and the seismograms for the station S0006 already exists within the traces folder
include/policies/chunk.hpp
Outdated
| : Base(indices, ngllz, ngllx), mapping(mapping) {} | ||
|
|
||
| KOKKOS_INLINE_FUNCTION | ||
| const int imap(const int i) const { |
There was a problem hiding this comment.
Can you call the Base::operator(i) method to compute ielement here? Incase in the future we update the orientation of threads then we dont need to remember to update it in 2 locations.
|
|
||
| KOKKOS_INLINE_FUNCTION | ||
| mapped_iterator_type mapped_league_iterator(const int start_index) const { | ||
| const int start = start_index; |
There was a problem hiding this comment.
- Can this just be called
league_iterator?
There was a problem hiding this comment.
I got the error mapped_element_chunk and element_chunk are not compatible when trying to override league_iterator.
| @@ -84,7 +84,7 @@ void specfem::kokkos_kernels::impl::compute_seismograms( | |||
|
|
|||
| receivers.set_seismogram_step(isig_step); | |||
|
|
|||
| ChunkPolicy policy(elements, ngll, ngll); | |||
| ChunkPolicy policy(elements, receiver_indices, ngll, ngll); | |||
There was a problem hiding this comment.
I ended up updating the naming of the policy, index, iterator etc. for more clarity:
policy -> mapped_policy
iterator -> mapped_iterator
index -> element_index
But it is fine the way it is here
Issue Number
Closes #422