-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discontinuous Galerkin (dG) #220
Open
int-ptr-ptr
wants to merge
19
commits into
PrincetonUniversity:devel
Choose a base branch
from
int-ptr-ptr:dg-forward
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ acoustic-elastic interface base code in, still need to test it + fixed a bug where abs is used instead of fabs, causing NaN start/end params + added a config.yaml -> param builder pattern function
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
+ display support + removals between different materials + writers (seismo,...) works with setup and params
+ acoustic-elastic tested vs cG + coupled interfaces are properly removed when setting dG + implemented a new algorithm for intersections; curves should work now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the changes/features in this pull request.
This PR is the (WIP) implementation for dG / mortar method.
As of the current stage of development, we are utilizing an event system pattern, where events are queued as (function, float) pairs, which I am calling events, where the functions are called in order of increasing floating point value, effectively serving as a program with a continuous, rather than integer, program counter. The current implementation is rather bare-bones as things like interrupts and stack traces are unneeded for my purposes at the moment.
Issue Number
If there is an issue created for these changes, link it here
TODOs
edge.data
is not the mess that it is now..._on_device
methodsPointViewType
-like structs)foreach
methods -- we could keepstd::function
args as an..._on_host
overload, but some way of having an inline-able Kokkos function is probably necessary.Checklist
Please make sure to check developer documentation on specfem docs.