Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devel #700

Merged
merged 87 commits into from
Mar 5, 2018
Merged

Devel #700

merged 87 commits into from
Mar 5, 2018

Conversation

KristenManning
Copy link
Contributor

No description provided.

jdcpni added 30 commits February 2, 2018 07:39
…Link into refactor/Projection/Context_devel

# Conflicts:
#	psyneulink/components/mechanisms/adaptive/control/controlmechanism.py
… and 'devel' of https://github.com/PrincetonUniversity/PsyNeuLink into clean_up/function_and_system/backprop_and_show_graph

# Conflicts:
#	psyneulink/components/functions/function.py
  replace calcuate/CACULATE with assign/ASSIGN
  replace calcuate/CACULATE with assign/ASSIGN
  replace calcuate/CACULATE with assign/ASSIGN
  added backward compatibility
  docstring: document replacement of calcuate/CACULATE with assign/ASSIGN
  - implemented assign that takes assign_params_dict as arg
  assign function now expects dict as argument - WORKING
jdcpni and others added 29 commits February 28, 2018 09:23
  docstring revs
  docstring revs
  docstring revs
  _instantiate_learning_graph(): fixed bug in which learning failed to
    be instantiated for a System in which the last Mechanism in a
    learning sequence was not the TERMINAL Mechanism of the System.
  _instantiate_learning_graph(): fixed bug in which learning failed to
    be instantiated for a System in which the last Mechanism in a
    learning sequence was not the TERMINAL Mechanism of the System.
  Rumelhart Semantic Network: updated with step function
  _instantiate_control_signals:  debugged OWNER_VALUE assignment
…rminal"

This reverts commit 5c46c1d, reversing
changes made to ba8dacb.
…ends_before_terminal

Fix/system/learning ends before terminal
…e/retire_assign_merge_devel

Refactor/output state/retire assign merge devel
* • Scripts/Examples
  Rumelhart Semantic Network: updated with step function

* • Scripts/Examples
  Rumelhart Semantic Network: updated with step function

* -

* • Examples
  Rumelhart Semantic Network script
* • Scripts/Examples
  Rumelhart Semantic Network: updated with step function

* • Scripts/Examples
  Rumelhart Semantic Network: updated with step function

* -

* • Examples
  Rumelhart Semantic Network script

* • Examples
  Rumelhart Semantic Network script:
      eliminated explicit implementation of Step function;
      now assigns Python-defined step function directly
…ather than param base values), and are updated whenever mechanisms update their parameter states
…dict/parameter-state-values

user_params and function_params now look at parameter state values (r…
* -

* -

* -

* -

* -

* -

* • DDM
  __init__:
    Modified implement DECISION_VARIABLE_ARRAY and SELECTED_INPUT_ARRAY
      as StandardOutputStates

• OutputState
  StandardOutputStates: added add_state_dicts method

• Scripts
  RL-DDM:  modified to used SELECTED_INPUT_ARRAY

* -

* -

* • DDM
  docstring revs for DECISION_VARIABLE_ARRAY and SELECTED_INPUT_ARRAY

• Mechanism
  _update_params_dicts:  new method, called by _update_parameter_states
                         and _instantiate_output_states
  - !!!HACK ALERT!!! had to put an exclude for noise (causes crash) --
    this needs to be fixed

* -
* -

* -

* -

* -

* -

* -

* • DDM
  __init__:
    Modified implement DECISION_VARIABLE_ARRAY and SELECTED_INPUT_ARRAY
      as StandardOutputStates

• OutputState
  StandardOutputStates: added add_state_dicts method

• Scripts
  RL-DDM:  modified to used SELECTED_INPUT_ARRAY

* -

* -

* • DDM
  docstring revs for DECISION_VARIABLE_ARRAY and SELECTED_INPUT_ARRAY

• Mechanism
  _update_params_dicts:  new method, called by _update_parameter_states
                         and _instantiate_output_states
  - !!!HACK ALERT!!! had to put an exclude for noise (causes crash) --
    this needs to be fixed

* -

* -

* • Mechanism
  - _upate_params_dicts:  restricted skipping of noise to INIT

• Tests
  - test_parameter_states:  reinstated tests for setting noise
* • LearningProjection
  __init__: added error_function as an argument/attribute

• LearningAuxiliary
  _instantiated_learning_components:
     now uses error_function attribute of LearningProjection
     (if specified) to assign the function to the ComparatorMechanism

* • LearningProjection
  __init__: added error_function as an argument/attribute

• LearningAuxiliary
  _instantiated_learning_components:
     now uses error_function attribute of LearningProjection
     (if specified) to assign the function to the ComparatorMechanism
  docstring rev (to include error_function)
…ion/error_function

• LearningProjection
@KristenManning KristenManning merged commit 261f368 into master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants