Fix/system/learning ends before terminal #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rumelhart Semantic Network: updated with step function
KristenManning
added a commit
that referenced
this pull request
Mar 2, 2018
This reverts commit a75aeb0.
KristenManning
added a commit
that referenced
this pull request
Mar 2, 2018
…tem/learning-ends-before-terminal Revert "Fix/system/learning ends before terminal (#685)"
jdcpni
added a commit
that referenced
this pull request
Apr 13, 2018
* Fix/system/learning ends before terminal (#685) * • System _instantiate_learning_graph(): fixed bug in which learning failed to be instantiated for a System in which the last Mechanism in a learning sequence was not the TERMINAL Mechanism of the System. * • System _instantiate_learning_graph(): fixed bug in which learning failed to be instantiated for a System in which the last Mechanism in a learning sequence was not the TERMINAL Mechanism of the System. * • Scripts/Examples Rumelhart Semantic Network: updated with step function * Revert "Fix/system/learning ends before terminal (#685)" This reverts commit a75aeb0. * • Environment Run: removed _parse_target_labels (they are just the input_labels for a TARGET Mechanism • Mechanism docstring revs for INPUT_LABELS_DICDT and OUTPUT_LABELS_DICT * - * - * - * - * - * • Component - _execute: added **kwargs argument, passed to call to function to accomodate LearningMechanism that uses this • AutoassociativeLearningMechanism - _execute calls super(LearningMechanism, self) to skip Learning • LearningMechanism: _ execute calls super()._execute with **kwargs * • Component - _execute: added **kwargs argument, passed to call to function to accomodate LearningMechanism that uses this • AutoassociativeLearningMechanism - _execute calls super(LearningMechanism, self) to skip Learning • LearningMechanism: _ execute calls super()._execute with **kwargs • PrecictionMechanism: _execute calls super()._execute * • Component - _execute: added **kwargs argument, passed to call to function to accomodate LearningMechanism and EVCControlMechanism, the functions for which expect additional arguments • AutoassociativeLearningMechanism - _execute calls super(LearningMechanism, self) to skip Learning • LearningMechanism: _ execute calls super()._execute with **kwargs • PrecictionMechanism: _execute calls super()._execute * • Component - _execute: added **kwargs argument, passed to call to function to accomodate LearningMechanism and EVCControlMechanism, the functions for which expect additional arguments • AutoassociativeLearningMechanism - _execute calls super(LearningMechanism, self) to skip Learning • LearningMechanism: _ execute calls super()._execute with **kwargs • PrecictionMechanism: _execute calls super()._execute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• System
_instantiate_learning_graph(): fixed bug in which learning failed to
be instantiated for a System in which the last Mechanism in a
learning sequence was not the TERMINAL Mechanism of the System.
• Scripts/Examples
Rumelhart Semantic Network: updated with final Projection (that doesn't learn) and Mechanism (using step function)