-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/log/log with time #582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parison of random numbers between python and matlab
…Link into feat/normal-dist/matlab
* • System - show_graph(): fixed bug producing empty image for graphs with just one Mechanism added auto-recurrent projections * • Component - deferred_init: fixed bug in which "Deferred Init" was remaining in name of initialized Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Moved call to _assign_default_projection_name from MappingProjection to Projection * • State - _validate_variable: removed: if not context: context = kwAssign + ' Base Value' else: context = context + kwAssign + ' Base Value' * • State - _validate_variable: removed: if not context: context = kwAssign + ' Base Value' else: context = context + kwAssign + ' Base Value' * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • Mechanism - added states and projections properties (as well as ones for each projection time) - added log_items property that returns a list of logged items and allows them to be set • State - fixed a bug preventing proper logging * • Mechanism - added states and projections properties (as well as ones for each projection time) - added log_items property that returns a list of logged items and allows them to be set • State - fixed a bug preventing proper logging * - * - * - * - * - * • README.rst and index.rst: revs to Intro, Purpose, and Contributors * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * - * - * - * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * - * - * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * - * - * - * - * - * - * - * - * - * - * - * - * -
* • System - show_graph(): fixed bug producing empty image for graphs with just one Mechanism added auto-recurrent projections * • Component - deferred_init: fixed bug in which "Deferred Init" was remaining in name of initialized Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Moved call to _assign_default_projection_name from MappingProjection to Projection * • State - _validate_variable: removed: if not context: context = kwAssign + ' Base Value' else: context = context + kwAssign + ' Base Value' * • State - _validate_variable: removed: if not context: context = kwAssign + ' Base Value' else: context = context + kwAssign + ' Base Value' * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • Mechanism - added states and projections properties (as well as ones for each projection time) - added log_items property that returns a list of logged items and allows them to be set • State - fixed a bug preventing proper logging * • Mechanism - added states and projections properties (as well as ones for each projection time) - added log_items property that returns a list of logged items and allows them to be set • State - fixed a bug preventing proper logging * - * - * - * - * - * • README.rst and index.rst: revs to Intro, Purpose, and Contributors * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * - * - * - * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * - * - * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * - * - * - * - * - * - * - * - * - * - * - * - * - * • Log - added an example to docstring
…licative param(s) of modulated mechanism(s) properly
…Link into fix/lc-control-mechanism/modulation
…nism/modulation Fix/lc control mechanism/modulation
* • System - show_graph(): fixed bug producing empty image for graphs with just one Mechanism added auto-recurrent projections * • Component - deferred_init: fixed bug in which "Deferred Init" was remaining in name of initialized Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Moved call to _assign_default_projection_name from MappingProjection to Projection * • State - _validate_variable: removed: if not context: context = kwAssign + ' Base Value' else: context = context + kwAssign + ' Base Value' * • State - _validate_variable: removed: if not context: context = kwAssign + ' Base Value' else: context = context + kwAssign + ' Base Value' * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • Mechanism - added states and projections properties (as well as ones for each projection time) - added log_items property that returns a list of logged items and allows them to be set • State - fixed a bug preventing proper logging * • Mechanism - added states and projections properties (as well as ones for each projection time) - added log_items property that returns a list of logged items and allows them to be set • State - fixed a bug preventing proper logging * - * - * - * - * - * • README.rst and index.rst: revs to Intro, Purpose, and Contributors * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * - * - * - * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * - * - * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * - * - * - * - * - * - * - * - * - * - * - * - * - * • Log - added an example to docstring * - * • Log - docstring: added full example (including logging a MappingProjection) * • Log - docstring: added full example (including logging a MappingProjection) * • Log - docstring: added full example (including logging a MappingProjection)
* • System - show_graph(): fixed bug producing empty image for graphs with just one Mechanism added auto-recurrent projections * • Component - deferred_init: fixed bug in which "Deferred Init" was remaining in name of initialized Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Component - added call to _assign_default_name() • PathwayProjection, Projection - added _assign_default_name to trap call from Component * • Moved call to _assign_default_projection_name from MappingProjection to Projection * • State - _validate_variable: removed: if not context: context = kwAssign + ' Base Value' else: context = context + kwAssign + ' Base Value' * • State - _validate_variable: removed: if not context: context = kwAssign + ' Base Value' else: context = context + kwAssign + ' Base Value' * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • Mechanism - added states and projections properties (as well as ones for each projection time) - added log_items property that returns a list of logged items and allows them to be set • State - fixed a bug preventing proper logging * • Mechanism - added states and projections properties (as well as ones for each projection time) - added log_items property that returns a list of logged items and allows them to be set • State - fixed a bug preventing proper logging * - * - * - * - * - * • README.rst and index.rst: revs to Intro, Purpose, and Contributors * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * • Mechanism - docstring: updated to include states, and projections attributes * - * - * - * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * - * - * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * Merge branch 'TEMP' of https://github.com/jdcpni/PsyNeuLink into TEMP # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/projections/pathway/mappingprojection.py # psyneulink/components/projections/projection.py # psyneulink/components/states/inputstate.py # psyneulink/components/states/modulatorysignals/controlsignal.py # psyneulink/components/states/outputstate.py # psyneulink/components/states/parameterstate.py # psyneulink/components/states/state.py # tests/mechanisms/test_input_state_spec.py # tests/projections/test_projections_specifications.py * - * - * - * - * - * - * - * - * - * - * - * - * - * • Log - added an example to docstring * - * • Log - added numpy_array output method
* • System - show_graph(): fixed bug producing empty image for graphs with just one Mechanism added auto-recurrent projections * • Log - added numpy_array output method * • Mechanism - added senders, modulators and receivers properties * • Mechanism - added senders, modulators and receivers properties * -
* • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • Log - changed name of numpy_array method to nparray and added to docstring
…Link into feat/normal-dist/matlab
* • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * • Log - minor revs to docstring
…Link into feat/normal-dist/matlab
…nUniversity/PsyNeuLink into feat/normal-dist/matlab
* • System - show_graph(): bug fix for ControlProjections * • System - show_graph(): bug fix for ControlProjections * - * - * - * - * - * - * • Log - refactored to keep data for a Compoent in its *own* Log, and have others that require that data to reference it * • Log - LogLevels converted to masks - _get_log_context method added that checks context against mask - tests of context for logging now use _get_log_context * - * - * - * • Log, State, Projection - consolidated logging of value in Log._log_value * - * • ControlSignal - adding call to logg in value property • Log: Commented places ("FIX: IMPLEMENT EXECUTION+LEARNING CONDITION") that need refactoring to fully implement LogLevel and get_log_context * • Log - added value of owner as loggable_component * • Log - added value of owner as loggable_component * • Log - log_item: allows LogLevel names to be used for specification • Keywords - LogLevel names added as keywords
- consolidated logging of value in Log._log_value
…ep time, used in Scheduler and Conditions Clock has Time and TimeHistoryTree Time/SimpleTime store a representation of time using TimeScales TimeHistoryTree stores a representation of present and past time, keeping track of the number of times various TimeScales have occurred under the scope of other TimeScales
* feat/scheduling/enhanced-clock: create and integrate a new Clock class, and several new classes to keep time, used in Scheduler and Conditions remove old Clock/CentralClock
…Link into MERGE_WITH_CLOCK # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/mechanisms/mechanism.py # psyneulink/components/projections/projection.py # psyneulink/components/states/state.py # psyneulink/components/system.py # psyneulink/globals/log.py # tests/learning/test_multilayer.py
…Link into feat/Log/log_with_time # Conflicts: # Scripts/Scratch Pad.py # psyneulink/components/mechanisms/mechanism.py # psyneulink/components/projections/projection.py # psyneulink/components/states/state.py # psyneulink/components/system.py # psyneulink/globals/log.py # tests/learning/test_multilayer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Log
• Tests