fix/standard_output_ports_calculate #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Link into devel # Conflicts: # Scripts/Models (Under Development)/EGO/Using EMComposition/ScriptControl.py # Scripts/Models (Under Development)/EGO/Using EMComposition/TestParams.py
…Link into devel # Conflicts: # Scripts/Models (Under Development)/EGO/Using EMComposition/CSW/ScriptControl.py
- _instantiate_attributes_after_function(): fix assignment of StabilityFunction, and force update of default_variable for output_port
…com/PrincetonUniversity/PsyNeuLink into fix/standard_output_ports_calculate # Conflicts: # psyneulink/library/components/mechanisms/processing/transfer/recurrenttransfermechanism.py
|
This PR causes the following changes to the html docs (ubuntu-latest-3.11): See CI logs for the full diff. |
…Link into fix/standard_output_ports_calculate
|
This PR causes the following changes to the html docs (ubuntu-latest-3.11): See CI logs for the full diff. |
…Link into fix/standard_output_ports_calculate
_instantiate_attributes_after_function: revise call to _update_default_variable to use energy.variable instead of value
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+354
to
+355
| # elif isinstance(matrix, ParameterPort): | ||
| # pass |
Check notice
Code scanning / CodeQL
Commented-out code Note
| @@ -193,10 +193,11 @@ | |||
|
|
|||
| from psyneulink.core import llvm as pnlvm | |||
| from psyneulink.core.components.component import _get_parametervalue_attr | |||
| from psyneulink.core.components.functions.nonstateful.transferfunctions import Linear | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
| @@ -193,10 +193,11 @@ | |||
|
|
|||
| from psyneulink.core import llvm as pnlvm | |||
| from psyneulink.core.components.component import _get_parametervalue_attr | |||
| from psyneulink.core.components.functions.nonstateful.transferfunctions import Linear | |||
Check notice
Code scanning / CodeQL
Unused import Note
| from psyneulink.core.components.functions.nonstateful.transformfunctions import LinearCombination | ||
| from psyneulink.core.components.functions.function import Function, get_matrix | ||
| from psyneulink.core.components.functions.nonstateful.learningfunctions import Hebbian | ||
| from psyneulink.core.components.functions.nonstateful.objectivefunctions import Stability | ||
| from psyneulink.core.components.functions.nonstateful.objectivefunctions import Stability, Energy, Entropy |
Check notice
Code scanning / CodeQL
Cyclic import Note
| from psyneulink.core.components.functions.nonstateful.transformfunctions import LinearCombination | ||
| from psyneulink.core.components.functions.function import Function, get_matrix | ||
| from psyneulink.core.components.functions.nonstateful.learningfunctions import Hebbian | ||
| from psyneulink.core.components.functions.nonstateful.objectivefunctions import Stability | ||
| from psyneulink.core.components.functions.nonstateful.objectivefunctions import Stability, Energy, Entropy |
Check notice
Code scanning / CodeQL
Unused import Note
|
This PR causes the following changes to the html docs (ubuntu-latest-3.11): See CI logs for the full diff. |
_instantiate_attributes_after_function: revise call to _update_default_variable to use energy.variable instead of value
|
This PR causes the following changes to the html docs (ubuntu-latest-3.11): See CI logs for the full diff. |
- TestStandardOutputPorts:
test_rtn_energy()
test_rtn_entropy()
|
This PR causes the following changes to the html docs (ubuntu-latest-3.11): See CI logs for the full diff. |
_instantiate_attributes_after_function():
refactor to assign functions for ENERGY and ENTROPY standard_output_ports before call to super()
|
This PR causes the following changes to the html docs (ubuntu-latest-3.11): See CI logs for the full diff. |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.11): See CI logs for the full diff. |
…Link into fix/standard_output_ports_calculate
|
This PR causes the following changes to the html docs (ubuntu-latest-3.11): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• recurrenttransfermechanism.py
- _instantiate_attributes_after_function(): fix assignment of functions to ENERGY and ENTROPY standard_output_ports
• test_recurrent_transfermechanism.py