llvm: Store only pointee types in byref_arg_types for pointer arguments #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'_type_' special attribute stores pointee type for pointers [0], array element type for arrays[1], but string type representation for other types. Adjust builtin tests to not rely on byref_arg_types of non-pointer arguments. Cleanup codestyle in builtin tests. Use np.sum() instead of sum() to keep the result in the same precision as the input array. [0] https://docs.python.org/3/library/ctypes.html#ctypes._Pointer._type_ [1] https://docs.python.org/3/library/ctypes.html#ctypes.Array._type_ Signed-off-by: Jan Vesely <[email protected]>
|
This PR causes the following changes to the html docs (ubuntu-latest-3.11): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'type' special attribute stores pointee type for pointers [0], array element type for arrays[1], but string type representation for other types.
Adjust builtin tests to not rely on byref_arg_types of non-pointer arguments. Cleanup codestyle in builtin tests.
Use np.sum() instead of sum() to keep the result in the same precision as the input array.
[0] https://docs.python.org/3/library/ctypes.html#ctypes._Pointer._type_
[1] https://docs.python.org/3/library/ctypes.html#ctypes.Array._type_