Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm: Remove workaround, rename node assembly #3016

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented Jul 27, 2024

Remove workaround in used parameters check. Unused parameters should be added to the blocklist in Component.
Rename node_wrapper -> node assembly to avoid confusion with wrapped nodes.

jvesely added 2 commits July 26, 2024 21:28
Add a comment explaining the purpose of the check.

Signed-off-by: Jan Vesely <[email protected]>
Avoid confusion with wrapped nodes used e.g. in pytorch

Signed-off-by: Jan Vesely <[email protected]>
@jvesely jvesely added the compiler Runtime Compiler label Jul 27, 2024
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.11):

No differences!

...

See CI logs for the full diff.

@jvesely jvesely merged commit d622a29 into PrincetonUniversity:devel Jul 27, 2024
36 checks passed
@jvesely jvesely deleted the devel-fix branch July 27, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Runtime Compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant