Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm: AutoassociativeProjection is a PNL param of the Mechanism #2941

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented Apr 10, 2024

Remove explicit inclusion of the recurrent projection in the compiled structures.
Filter out Autoassociative projections from the list of composition projections.

jvesely added 3 commits April 9, 2024 22:40
Pure refactoring, no function change.

Signed-off-by: Jan Vesely <[email protected]>
…t_projection in compiled structures

It's now listed in parameters.
Allow writeback of the projection parameters.

Signed-off-by: Jan Vesely <[email protected]>
…osition projection list

The are part of their respective mechanism's structures.
This saves ~8B per projection in compiled composition param structure,
and 8-72B+ per projection in compiled composition state structure.

Signed-off-by: Jan Vesely <[email protected]>
@jvesely jvesely added the compiler Runtime Compiler label Apr 10, 2024
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.11-x64):

No differences!

...

See CI logs for the full diff.

@jvesely jvesely changed the title llvm: RTM AutoassociativeProjection is a PNL param of its Mechanism llvm: AutoassociativeProjection is a PNL param of the Mechanism Apr 10, 2024
@jvesely jvesely merged commit d53cb41 into PrincetonUniversity:devel Apr 11, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Runtime Compiler
Projects
Development

Successfully merging this pull request may close these issues.

1 participant