autodiff_composition: Allow using torch 1.11 with python3.10 and Windows #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvesely
added
bug
|
I'm not 100% sure about the extra dimension in the <1.12.0 path, but it's enough to make the tests pass |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -4,3 +4,17 @@ | |||
| __all__ = list(regressioncfa.__all__) | |||
| __all__.extend(compositionrunner.__all__) | |||
| __all__.extend(autodiffcomposition.__all__) | |||
|
|
|||
| try: | |||
| import torch | |||
Check notice
Code scanning / CodeQL
Module is imported with 'import' and 'import from'
Signed-off-by: Jan Vesely <[email protected]>
jvesely
force-pushed
the
torch
branch
2 times, most recently
from
b723a4d to
aff25fa
Compare
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
…torch<=1.11.x d6d95f3 ("Nback (PrincetonUniversity#2617)") changed the format of cross entropy target that requires torch >=1.12 1.12.0+ includes input handling path to consider inputs without batch dimension and can be used directly. [0,1,2] Fixes: d6d95f3 ("Nback (PrincetonUniversity#2617)") Closes: PrincetonUniversity#2665 [0] https://github.com/pytorch/pytorch/releases/tag/v1.12.0 [1] pytorch/pytorch#77653 [2] pytorch/pytorch@8881d7a Signed-off-by: Jan Vesely <[email protected]>
pytorch/pytorch#100690 1.11.0 also has this problem, but it was built using numpy 1.22 which is supported in PNL. Signed-off-by: Jan Vesely <[email protected]>
Assert that torch is usable if installed during testing. Signed-off-by: Jan Vesely <[email protected]>
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block all torch wheels on windws+python3.10.
Add compatibility code path for torch <1.12.0.
Check for the availability of torch numpy bindings instead of the Python/OS version.