Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add run using --benchmark-enable #2630

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented Apr 11, 2023

This does not monitor performance, it just checks that the tests pass if the benchmark fixture runs multiple iterations of the benchmarked call.

…t of learning results

The 'benchmark' fixture runs and arbitrary number of iterations.
Because of this it is override in conftest.py to preserve the return
value of the first invocation. However, this only applies to explicitly
returned values, not stateful variables.

Add a helper function that returns 'learning_results' to workaround
this restriction.

Fixes --benchmark-enable test in AutodiffComposition
Fixes: 521a4a2 ("Tentative learning branch (PrincetonUniversity#2623)")

Signed-off-by: Jan Vesely <[email protected]>
@jvesely jvesely added CI Continuous Integration tests Test changes labels Apr 11, 2023
@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

This is not monitoring performance, just making sure the benchmark
variants pass without error.

Signed-off-by: Jan Vesely <[email protected]>
@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

@jvesely jvesely merged commit ec93b2d into PrincetonUniversity:devel Apr 11, 2023
@jvesely jvesely deleted the devel-bench branch April 11, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tests Test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant