Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions: Constraint broken transitive dependencies #2603

Merged
merged 1 commit into from
Feb 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/install-pnl/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ runs:
echo "new_package=$NEW_PACKAGE" >> $GITHUB_OUTPUT
# save a list of all installed packages (including pip, wheel; it's never empty)
pip freeze --all > orig
pip install "$(echo $NEW_PACKAGE | sed 's/[-_]/./g' | xargs grep *requirements.txt -h -e | head -n1)" -c env_constraints.txt
pip install "$(echo $NEW_PACKAGE | sed 's/[-_]/./g' | xargs grep *requirements.txt -h -e | head -n1)" -c env_constraints.txt -c broken_trans_deps.txt
pip show "$NEW_PACKAGE" | grep 'Version' | tee new_version.deps
# uninstall new packages but skip those from previous steps (pywinpty, terminado on windows x86)
# the 'orig' list is not empty (includes at least pip, wheel)
Expand All @@ -82,7 +82,7 @@ runs:
- name: Python dependencies
shell: bash
run: |
pip install -e .[${{ inputs.features }}] -c env_constraints.txt
pip install -e .[${{ inputs.features }}] -c env_constraints.txt -c broken_trans_deps.txt

- name: "Cleanup old wheels"
shell: bash
Expand Down
5 changes: 5 additions & 0 deletions broken_trans_deps.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# This file constraints broken (transitive) dependencies

# onnxruntime-1.14.0 is broken on macos/x64
# https://github.com/microsoft/onnxruntime/issues/14663
onnxruntime != 1.14.0; platform_system=="Darwin"