Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: Bump minimum numpy version to 1.19.0 #2583

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented Jan 14, 2023

Calling gcd on list comprehension fails with numpy<1.19.0

Closes: #2581

Signed-off-by: Jan Vesely [email protected]

Calling gcd on list comprehension fails on <1.19.0

Closes: PrincetonUniversity#2581

Signed-off-by: Jan Vesely <[email protected]>
@jvesely jvesely added the deps Dependency update label Jan 14, 2023
@jvesely jvesely requested a review from kmantel January 14, 2023 04:25
@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

Copy link
Collaborator

@kmantel kmantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this belongs at least on graph-scheduler, I'll go ahead and add that. I suppose it's good to add here too because old scheduler versions could still be used that won't have that bound

@jvesely jvesely merged commit c1592c1 into PrincetonUniversity:devel Jan 14, 2023
kmantel added a commit to kmantel/graph-scheduler that referenced this pull request Jan 18, 2023
failure on calling gcd on list comprehension.
see PrincetonUniversity/PsyNeuLink#2583
kmantel added a commit to kmantel/graph-scheduler that referenced this pull request Jan 18, 2023
failure on calling gcd on list comprehension.
see PrincetonUniversity/PsyNeuLink#2583
kmantel added a commit to kmantel/graph-scheduler that referenced this pull request Jan 18, 2023
failure on calling gcd on list comprehension.
see PrincetonUniversity/PsyNeuLink#2583
kmantel added a commit to kmantel/graph-scheduler that referenced this pull request Jan 18, 2023
failure on calling gcd on list comprehension.
see PrincetonUniversity/PsyNeuLink#2583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Dependency update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants