Nback #2540
Merged
Nback #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Link into devel � Conflicts: � Scripts/Models (Under Development)/N-back.py
- add save and load methods (from Samyak)
- test_autodiffcomposition.py:
add test_autodiff_saveload, but commented out for now, as it may be causing hanging on PR
- add save and load methods (from Samyak)
- test_autodiffcomposition.py:
add test_autodiff_saveload, but commented out for now, as it may be causing hanging on PR
…Link into feat/autodiff_various � Conflicts: � Scripts/Models (Under Development)/N-back.py � tests/mdf/model_basic.yml
- pytorch_function_creator: add SoftMax • transferfunctions.py: - disable changes to ReLU.derivative for now
- iscompatible:
attempt to replace try and except, commented out for now
…Link into devel � Conflicts: � Scripts/Models (Under Development)/N-back.py
…Link into feat/autodiff_various
- save and load: augment file and directory handling - exclude processing of any ModulatoryProjections
save(): add projection.matrix.base = matrix
(fixes test_autodiff_saveload)
- save: return path • test_autodiffcomposition.py: - test_autodiff_saveload: modify to use current working directory rather than tmp
- save() and load(): ignore CIM, learning, and other modulation-related projections
…Link into devel Conflicts: .github/actions/install-pnl/action.yml .github/actions/on-branch/action.yml .github/workflows/pnl-ci-docs.yml .github/workflows/pnl-ci.yml .github/workflows/test-release.yml Scripts/Models (Under Development)/N-back.py
…Link into devel Conflicts: .github/actions/install-pnl/action.yml .github/actions/on-branch/action.yml .github/workflows/pnl-ci-docs.yml .github/workflows/pnl-ci.yml .github/workflows/test-release.yml Scripts/Models (Under Development)/N-back.py
- test_xor_training_identicalness_standard_composition_vs_PyTorch_vs_LLVM:
replaces test_xor_training_identicalness_standard_composition_vs_Autodiff
- BackPropagation:
- fix bug in which derivative for default loss (MSE) was computed using L0
- add explicit specification for L0 loss
• composition.py:
- _create_terminal_backprop_learning_components:
- add explicit assignment of output_port[SUM] for L0 loss
• test_learning.py:
- test_multilayer:
- fix bug in which SSE was assigned as loss, but oputput_port[MSE] was used for objective_mechanism
- replace with explicit L0 loss and ouput_port[SUM] for objective_mechanism
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
This pull request introduces 18 alerts and fixes 2 when merging 98e6525 into 89d2561 - view on LGTM.com new alerts:
fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
- clean up test_xor_training_identicalness_standard_composition_vs_PyTorch_and_LLVM
jvesely
reviewed
Nov 18, 2022
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This pull request introduces 11 alerts and fixes 6 when merging a46be70 into 89d2561 - view on LGTM.com new alerts:
fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
- clean up test_xor_training_identicalness_standard_composition_vs_PyTorch_and_LLVM
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This pull request introduces 10 alerts and fixes 6 when merging 787e8a4 into 89d2561 - view on LGTM.com new alerts:
fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR has many changes to learning, as well as the nback script.
• nback.py:
to match and validate against version in Beukers et al., 2022:
• transferfunctions.py:
• learningfunctions.py
• combinationfunctions.py:
• pytorchmodelcreator.py:
• compiledloss.py:
• llvm/init.py:
• composition.py
• autodiffcomposition.py and keywords.py
• ComparatorMechanism:
• keywords.py:
• test_learning.py: