functions/ReLU,SoftMax: Restore functionality broken in #2528 #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the standard form for derivatives. Signed-off-by: Jan Vesely <[email protected]>
Commit cae1465 ("llvm, functions/SoftMax: Implement compiled 'derivative' variant") incorrectly assumed that the use of 'output' was an oversight. It wasn't SoftMax derivative can take advantage of results if available. This change restores the original functionality and adds a path to compute the results if output is None. This is used for testing where the results would need to be calculated anyway. The compiled variant is adapted in the same way, and the test are updated to reflect the new results. Signed-off-by: Jan Vesely <[email protected]>
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2528 introduced two breaking changes
1.) Renamed ReLU's derivative argument 'input'->'variable' which broke existing users of ReLU derivative.
2.) Changed SoftMax derivative calculation to use 'input' instead of 'output'. This is incorrect as the algorithm reuses existing outputs to calculate derivative results.
Both are restored to their original form. Moreover, a single input codepath is added to SoftMax,
recalculating results if they are not provided.
The compiled version and tests are adjusted accordingly.