-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/autodiff various #2524
Feat/autodiff various #2524
Conversation
…Link into devel � Conflicts: � Scripts/Models (Under Development)/N-back.py
- add save and load methods (from Samyak) - test_autodiffcomposition.py: add test_autodiff_saveload, but commented out for now, as it may be causing hanging on PR
- add save and load methods (from Samyak) - test_autodiffcomposition.py: add test_autodiff_saveload, but commented out for now, as it may be causing hanging on PR
…Link into feat/autodiff_various � Conflicts: � Scripts/Models (Under Development)/N-back.py � tests/mdf/model_basic.yml
- pytorch_function_creator: add SoftMax • transferfunctions.py: - disable changes to ReLU.derivative for now
- iscompatible: attempt to replace try and except, commented out for now
…Link into feat/autodiff_various
- save and load: augment file and directory handling - exclude processing of any ModulatoryProjections
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
save(): add projection.matrix.base = matrix (fixes test_autodiff_saveload)
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
1 similar comment
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
This pull request fixes 1 alert when merging cc9a24c into 259ccef - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging f04f295 into 259ccef - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging d5a5e55 into 259ccef - view on LGTM.com fixed alerts:
|
# Conflicts: # psyneulink/library/compositions/autodiffcomposition.py # tests/composition/test_autodiffcomposition.py
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
This pull request introduces 1 alert and fixes 1 when merging 846a880 into 259ccef - view on LGTM.com new alerts:
fixed alerts:
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
1 similar comment
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
This pull request introduces 1 alert and fixes 1 when merging ba27a4f into 259ccef - view on LGTM.com new alerts:
fixed alerts:
|
- fix path assignment bug
…Link into feat/autodiff_various � Conflicts: � .gitignore
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
1 similar comment
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
path = Path(os.getcwd()) | ||
if filename: | ||
# path = Path(path / filename) | ||
path = Path(os.path.join(path / filename)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path handling looks weird here. PosixPath
only works on POSIX OSes so it shouldn't be used in portable code.
Using Path
classes can directly use /
operator and don't need os.path.join
.
Using Path
object constructor on the result is redundant as well since the result of the overloaded operation is already a Path
object.
If using os.path.join
, the components should be provided as arguments (e.g. os.path.join('dir', 'filename')
and using Path
object is redundant.
This pull request introduces 1 alert and fixes 1 when merging c8d2825 into e741055 - view on LGTM.com new alerts:
fixed alerts:
|
• autodiffcomposition.py:
NOTE: not (yet) supported for Composition.learn()
use _runtime_learning_rate attribute for optimizer if provided in call to learn()
else use learning_rate specified at construction
• compositionrunner.py:
• test_autodiffcomposition.py: