Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node removal to Compositions #2364

Merged
merged 7 commits into from
Mar 29, 2022
Merged

Conversation

kmantel
Copy link
Collaborator

@kmantel kmantel commented Mar 29, 2022

Updates node removal with tested cases

Methods added:

  • Composition.remove_node
  • Projection.is_active_in_composition

@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

kmantel added 2 commits March 29, 2022 00:56
if a projection being learned is removed, disable the entire pathway
because the removal will break it
@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

@kmantel kmantel merged commit 3d76263 into PrincetonUniversity:devel Mar 29, 2022
@kmantel kmantel deleted the removenode branch March 29, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant