Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm: Add support for Philox PRNG #2194

Merged
merged 13 commits into from
Nov 9, 2021
Merged

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented Nov 9, 2021

Implementation matches numpy (1.17+).
Both fp32 and fp64 variants are available.
Add tests using Philox PRNG for all components that are compiled and need randomness.

Add and test both 64bit and 32bit versions.

Signed-off-by: Jan Vesely <[email protected]>
…stribution using Philox (fp64 only)

Signed-off-by: Jan Vesely <[email protected]>
Conflicts:
 * psyneulink/core/llvm/__init__.py:
 	Initialization of builtins was moved to builder_context,
	move setup_philox call there as well.

Signed-off-by: Jan Vesely <[email protected]>
The default is still Seeded(np.random.RandomState)

Signed-off-by: Jan Vesely <[email protected]>
Change duplicate test to not use the same rate.

Signed-off-by: Jan Vesely <[email protected]>
Functions:
 * ContentAddressableMemory
 * DictionaryMemory
 * DriftDiffusionIntegrator
 * GaussianDistort
 * GridSearch
 * NormalDist
 * OneHot
 * UniformDist

Mechanisms:
 * DDM

Signed-off-by: Jan Vesely <[email protected]>
@jvesely jvesely added the compiler Runtime Compiler label Nov 9, 2021
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 9, 2021

This pull request introduces 1 alert when merging 2e66553 into 736fccf - view on LGTM.com

new alerts:

  • 1 for Comparison using is when operands support `__eq__`

@jvesely jvesely merged commit 99da97a into PrincetonUniversity:devel Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Runtime Compiler
Projects
Development

Successfully merging this pull request may close these issues.

1 participant