llvm/cleanup/remove bitcasts #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvesely
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
thanks! it might be worth fixing the allocas (use alloca(m1.type.pointee ...) while here, but it can also be left for future cleanup.
alias analysis should have easier time handling out of bounds accesses than pointer casts.
we should still check that any data structure that we use doesn't insert extra padding.
It's probably not going to happen with fp64, but fp16 arrays can be padded/aligned to 4B
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes bitcasts from various lllvm pytorch helpers