Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge execution_id argument and context argument #1300

Merged
merged 3 commits into from
Sep 12, 2019

Conversation

kmantel
Copy link
Collaborator

@kmantel kmantel commented Sep 12, 2019

When previously both execution_id and context arguments were passed through functions, execution_id is now only accessed through context if necessary.

  • Parameter.get/set support Context objects as arguments, along with execution ids and Compositions
  • Parameter._get/_set only supports Context objects
  • Conditions and private Scheduler methods continue to use execution_id instead of context

…icable

	- some instances remain, but no duplicates of execution_id and context
	- execution_id argument is mainly still present in scheduling
	- separates internal and external calls logically
	- speed improvement
	- separates internal and external calls logically
    - speed improvement
@kmantel kmantel force-pushed the refac/context/merge-with-execution_id branch from eeb4491 to 02a0def Compare September 12, 2019 22:34
@coveralls
Copy link

coveralls commented Sep 12, 2019

Coverage Status

Coverage increased (+0.04%) to 77.971% when pulling 02a0def on refac/context/merge-with-execution_id into 422a679 on devel.

@kmantel kmantel merged commit 0696080 into devel Sep 12, 2019
@kmantel kmantel deleted the refac/context/merge-with-execution_id branch September 12, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants