Skip to content

Commit

Permalink
github-actions/release: Use TWINE_REPOSITORY_URL instead of TWINE_REP…
Browse files Browse the repository at this point in the history
…OSITORY

The latter needs configuration file to read the url from.

Signed-off-by: Jan Vesely <[email protected]>
  • Loading branch information
jvesely committed Nov 6, 2021
1 parent 9b97e40 commit 9a78bbc
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/test-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
# Include implicit dependency on setuptools{,-rust} and preinstall wheel
pip install setuptools setuptools-rust wheel
pip install twine
# This expects TWINE_USERNAME, TWINE_PASSWORD, and TWINE_REPOSITORY
# This expects TWINE_USERNAME, TWINE_PASSWORD, and TWINE_REPOSITORY_URL
# environment variables
# It's not possible to condition steps on env or secrets,
# We need an explicit check here
Expand All @@ -70,7 +70,7 @@ jobs:
env:
TWINE_USERNAME: ${{ secrets.TWINE_TEST_USERNAME }}
TWINE_PASSWORD: ${{ secrets.TWINE_TEST_PASSWORD }}
TWINE_REPOSITORY: ${{ secrets.TWINE_TEST_REPOSITORY }}
TWINE_REPOSITORY_URL: ${{ secrets.TWINE_TEST_REPOSITORY_URL }}


test-release:
Expand Down Expand Up @@ -167,7 +167,7 @@ jobs:
# Include implicit dependency on setuptools{,-rust} and preinstall wheel
pip3 install --user setuptools setuptools-rust wheel
pip3 install --user twine
# This expects TWINE_USERNAME, TWINE_PASSWORD, and TWINE_REPOSITORY
# This expects TWINE_USERNAME, TWINE_PASSWORD, and TWINE_REPOSITORY_URL
# environment variables
# It's not possible to condition steps on env or secrets,
# We need an explicit check here
Expand All @@ -179,7 +179,7 @@ jobs:
env:
TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
TWINE_REPOSITORY: ${{ secrets.TWINE_REPOSITORY }}
TWINE_REPOSITORY_URL: ${{ secrets.TWINE_REPOSITORY_URL }}

publish-github:
runs-on: ubuntu-latest
Expand Down

0 comments on commit 9a78bbc

Please sign in to comment.