Fix #47 & Improve Streamline Performance #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Before this change when the user was zoomed into a section of the domain and turned on the streamlines it would overlay the streamlines for the full domain onto the zoomed in section. This change fixes that so that only the streamlines in the zoomed section are plotted. Fixes PrincetonUniversity#47 Co-authored-by: Patrick Crumley <[email protected]>
In a few places the streamlines would be computed and plotted multiple times. I've removed those cases so that the streamlines will only be computed and plotted once. This should result in a noticeable speedup in plotting streamlines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #47 and fixes a few spots where the streamlines would be unnecessarily computed and plotted multiple times in a row; this should reduce the time to plot streamlines by 2-3x in many cases.
Credit to @pcrumley for figuring out what the fix for Issue #47 was.