You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Did a little more digging - we have viaf IDs ending with slashes but the RDF has URIs ending without the slash, so our lookups don't match and we don't get the dates we should be getting. (Maybe something changed with VIAF since the time this was implemented, or maybe we changed our local practice.). We can fix that part in the S&co codebase.
I also see that the date parsing doesn't handle negative years... That needs to be fixed in viapy.
We'll want to batch update records when this is fixed - maybe a one-off python console update would be sufficient in this case instead of a manage command (although log entries would be nice)
testing notes
In the S&co django admin, go to the person list and select a person record with a VIAF id but no birth/death dates even though VIAF record includes dates; save the record with "save and continue editing" - birth and death dates should be populated from VIAF
Find Aeschylus in the Person list and do the same thing (save and continue editing); birth/death dates should be added
The text was updated successfully, but these errors were encountered:
Did a little more digging - we have viaf IDs ending with slashes but the RDF has URIs ending without the slash, so our lookups don't match and we don't get the dates we should be getting. (Maybe something changed with VIAF since the time this was implemented, or maybe we changed our local practice.). We can fix that part in the S&co codebase.
I also see that the date parsing doesn't handle negative years... That needs to be fixed in viapy.
Originally posted by @rlskoeser in #800 (comment)
ViafEntity
, strip the trailing slashWe'll want to batch update records when this is fixed - maybe a one-off python console update would be sufficient in this case instead of a manage command (although log entries would be nice)
testing notes
The text was updated successfully, but these errors were encountered: