Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content admin, I want to export member addresses with more details in a separate file so I can more easily work with member locations. #790

Closed
5 tasks done
Tracked by #815
quadrismegistus opened this issue Oct 9, 2023 · 4 comments
Assignees

Comments

@quadrismegistus
Copy link
Contributor

quadrismegistus commented Oct 9, 2023

This ought to subclass BaseExport: https://github.com/Princeton-CDH/mep-django/blob/main/mep/people/management/commands/export_members.py

testing notes

  • JSON
  • confirm the structure of the export is as expected (includes the appropriate fields)
  • confirm the content of the export is as expected (spot check that correct content is in appropriate fields)
  • CSV
  • confirm the structure of the export is as expected (includes the appropriate fields)
  • confirm the content of the export is as expected (spot check that correct content is in

test export available in this google drive folder

question: do you have a preference between locations.csv or addresses.csv ?

dev notes

  • rename script and output to use addresses instead of locations
@rlskoeser
Copy link
Contributor

testing feedback from running the script: it outputs addresses & accounts as it runs, and probably should not (or should only in verbose mode)

@rlskoeser rlskoeser changed the title Write a new django manage command to export member addresses As a content admin, I want to export member addresses with more details in a separate file so I can more easily work with member locations. Apr 18, 2024
@rlskoeser rlskoeser moved this from Todo to In Progress in Iteration Planning Board Apr 18, 2024
rlskoeser added a commit that referenced this issue Apr 18, 2024
@rlskoeser rlskoeser moved this from In Progress to ⏱ Blocked in Iteration Planning Board Apr 18, 2024
@rlskoeser rlskoeser moved this from ⏱ Blocked to In Progress in Iteration Planning Board Apr 24, 2024
@rlskoeser rlskoeser moved this from In Progress to ⏱ Blocked in Iteration Planning Board May 2, 2024
@jkotin
Copy link

jkotin commented May 7, 2024

The JSON files are still not in the Google Drive file. The book, event, and member CSVs look perfect. The creators CSV looks good. It doesn't need a "title" column, but having the column doesn't cause any harm. The locations/addresses CSV also looks good—but I don't think we can release it with the current start/end data. (I discussed this with Ryan and I think, Rebecca.) Should I wait to look at the JSON files?

@jkotin
Copy link

jkotin commented May 7, 2024

Ah, I see a new link is in the email with the JSON files! I'll tackle ASAP.

@jkotin jkotin closed this as completed May 7, 2024
@github-project-automation github-project-automation bot moved this from ⏱ Blocked to Done in Iteration Planning Board May 7, 2024
@jkotin
Copy link

jkotin commented May 7, 2024

Looks looks perfect. My note about releasing the addresses without additional datawork still stands. But the export is excellent.

@jkotin jkotin reopened this May 7, 2024
@jkotin jkotin closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants