WEBREF-49 📦 Resolved react-side-effect dependency #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dep was previously resolving to a version which was actively using a deprecated lifecycle method and causing noise in the build/test log. The makers of the react-helmet library (which uses the dep), are working on a new release to overcome this: nfl/react-helmet#413 (comment). We'll pick this up with dependabot once it's out of beta.
Codecov Report
@@ Coverage Diff @@
## master #1297 +/- ##
==========================================
+ Coverage 86.56% 86.67% +0.11%
==========================================
Files 182 183 +1
Lines 1258 1261 +3
Branches 150 150
==========================================
+ Hits 1089 1093 +4
+ Misses 136 135 -1
Partials 33 33
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
SonyaMoisset
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dep was previously resolving to a version which was actively using a deprecated lifecycle method and causing noise in the build/test log.
The makers of the react-helmet library (which uses the dep), are working on a new release to overcome this: nfl/react-helmet#413 (comment).
We'll pick this up with dependabot once it's out of beta.