Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework options parsing to use grunt's built-in options parsing and fix outDir location. #4

Merged
merged 4 commits into from
Mar 18, 2014

Conversation

ssafejava
Copy link
Contributor

I found it frustrating that this module would not respect this common type of configuration used in grunt >= 0.4.0:

docker: {
  options: {
    // Common options for all tasks
    lineNums: true
  },
  ui: {
    src: ['ui/**/*.js', 'ui/README.md'],
    dest: 'docs'
  },
  node: {
    src: ['nodejs/lib/**/*.js', 'nodejs/README.md'],
    dest: 'docs'
  }
},

This PR enables the use of this.options(), provided by the task interface in Grunt.

There was a bug related to input directories; code inside Docker does some pretty bad munging of options.inDir and options.outDir, and as a result we need to fiddle with the inDir property if the documentation is being generated from a directory above this one.

I've also added a few bugfixes, removed some dead code, and added some notes related to the input/output directory.

Prevole pushed a commit that referenced this pull request Mar 18, 2014
Rework options parsing to use grunt's built-in options parsing and fix `outDir` location.
@Prevole Prevole merged commit 895a7f9 into Prevole:master Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants