Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more real exchanges, add some fake exchanges for testing and simulations, add placeholder country code #39

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Conversation

pgc-dev
Copy link
Member

@pgc-dev pgc-dev commented Jun 17, 2023

This PR does a few things:

  • Adds a lot more real exchanges, unfortunately I created a bit of a mess doing this and I tried to add more than the ones i needed directly, I will try to clean this up in a future PR but i wanted to scaffold things in case anyone else is looking to contribute
  • Adds placeholders for "paper trading" and "simulation", as well as the "XXXX" exchange
  • Add "XX" and "XXX" country codes for "uncategorized"
  • Added an enum for trading type with Live, Paper, Simulation, and Backtest

@timkpaine
Copy link
Collaborator

Thanks! This is a bit messy but I think it's fine for now, we should move these static/reference assets somewhere else if they're not needed but we can do that in a separate PR. I can do a release after merging as well?

@timkpaine timkpaine merged commit f937dfe into PrettyGoodCapital:main Jun 17, 2023
@pgc-dev pgc-dev deleted the pgc/exchanges-and-unknowns branch June 17, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants