-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aroma beta 17 incompatibilities, fix debug logger, bump version #28
Conversation
…gister boss tasks), and fix debug logger
Code looks good to me, though you've got mixed tabs/spaces. Might want to see if whatever editor your using has an EditorConfig plugin. |
…t of it (this is not considered a 100% functional commit
did a bunch of stuff but notifications still arent the way i wanted them to be, still a draft for now but i pushed all my latest changes so if anyone wants to take a look they can |
i do actually have multiple ides installed but i just use notepad++ because it starts quickly and is just files rather than folder/project based (i'll just end up using vscode anyways probably so its fineeeeee) |
oh crap, the commit i put has debug defaulted to on (you can just comment out the "DEBUG := 1" makefile line if you dont want debug but it will be commented before the pr is marked as ready for review) (i figured in general it would be good to have it in there in some form for beginners and such) |
I made a PR for that PR: TraceEntertains#1 |
Inkay-pretendo.zip |
Testing it and everything is working as expected, the message now shows up after boot and patching the wara wara plaza works now |
Using Aroma v19 with your release TraceEntertains and after a few reboots Mario Kart worked but for example with Splatoon (Lobby) I still get Error 101-0502/101-2210/ and others. It seems not to be 100% compatible to me for the moment. |
Error code 101-0502 Normally just means that the server is overloaded, idk about 101-2210 however |
It seems to be working for me on Aroma Beta 18, yesterday night I was able to play a Splatoon match. |
@jonbarrow PR generally seems to be working on Aroma Beta 17+, and its been sitting for a few days now, is it possible you could review this when you get the chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine though I have a few question marks. Happy to merge after this though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested with the latest commit and appears to be working fine for me - notification is showing, got 101-0502 (server overload which given Pretendo is a good sign the plugin works)
Edit: Got into a Splatoon match. To clarify how I built, I did not enable debugging.
Alright we'll call it good |
Pretty self explanatory
Works fine on my wii u but will mark as a draft until confirmed working