Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add product attribute shop content #396

Merged

Conversation

fox-john
Copy link
Contributor

No description provided.

@fox-john fox-john force-pushed the feature/pseventbus-v4-base branch from 5c07937 to 8997124 Compare November 22, 2024 14:36
@fox-john fox-john force-pushed the fix/add-product-attribute-shop-content branch from 153f5d0 to d0a22ae Compare November 22, 2024 14:40
Copy link

sonarcloud bot commented Nov 22, 2024

@fox-john fox-john added the 🥕 Radis to review Ready to reviewed by 1 peer label Nov 22, 2024
@fox-john fox-john self-assigned this Nov 22, 2024

use PrestaShop\Module\PsEventbus\Config\Config;

if (!defined('_PS_VERSION_')) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est pas obligatoire d'être en premier juste après le <?php ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cnavarro-prestashop Pas possible. Je sais plus quel est la partie qui fait ça, mais y'a une erreur qui remonte disant que le namespace et les use doivent être en premier.

@fox-john fox-john merged commit 92ef45f into feature/pseventbus-v4-base Nov 25, 2024
21 of 24 checks passed
@fox-john fox-john deleted the fix/add-product-attribute-shop-content branch November 25, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥕 Radis to review Ready to reviewed by 1 peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants