-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0007 - Add ADR about module modern installation and the container issues #8
Open
jolelievre
wants to merge
3
commits into
PrestaShop:master
Choose a base branch
from
jolelievre:module-installation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolelievre
force-pushed
the
module-installation
branch
from
March 9, 2020 18:04
e7d2150
to
d0ca02e
Compare
@PierreRambaud I applied your feedbacks on @jolelievre PR. Can you review again ? Let's merge this ! |
It looks like this ADR is kindof stale. We need to simply choose one solution and start using it everywhere. I suggest @eternoendless chooses the solution to use and then we can complete merge this ADR. |
…-advanced-installation.md
eternoendless
changed the title
Add ADR about module modern installation and the container issues
0007 - Add ADR about module modern installation and the container issues
Aug 21, 2020
@jolelievre if you are OK, maybe we should close this? we were not able to manage this topic until a vote |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ADR about module modern installation and the container issues