-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to ruff
for linting
#9283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zanieb
added
the
development
Tech debt, refactors, CI, tests, and other related work.
label
Apr 24, 2023
zangell44
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it's the hot new tool and it's way faster than our existing tools.
ruff --fix
This caught a bunch of shadowed test names resulting in missed test coverage or confusing duplication.
Note there's a minor gotcha when using
--fix
with ORM filters; see astral-sh/ruff#2443 (comment)I also installed the
Ruff
VSCode plugin which I would recommend.I started fixing all these E501 Line too long errors (which are mostly in documentation) but got sick of it and am not sure it improves readability or provides real value. I tried to disable the check for comments so it'd just check the code, but
black
will fix the code when it's too long so we don't really need to have it on at all.On
main
: