Change lazy loads from joined to selectin #8659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zanieb
approved these changes
Feb 27, 2023
ddelange
added a commit
to ddelange/prefect
that referenced
this pull request
Mar 1, 2023
…aceful-agent * 'patch-1' of https://github.com/ddelange/prefect: (25 commits) Enhancement: Track flow run id when generating task run results (PrefectHQ#8674) Fix loading of existing deployment descriptions from the server (PrefectHQ#8675) Update Dask logo (PrefectHQ#8669) Update `send_call` to `send_call_to_supervisor` (PrefectHQ#8653) Add Netlify Edge function to proxy to Segment (PrefectHQ#8657) Add security headers for docs (PrefectHQ#8655) Override analytics block instead of partial (PrefectHQ#8656) Add description flag to prefect deployment build CLI command (PrefectHQ#8603) Add support for yaml config strings to `KubernetesClusterConfig` (PrefectHQ#8643) Change lazy loads from joined to selectin (PrefectHQ#8659) Add timeout support to supervisors (PrefectHQ#8649) Minor markdown link fix in orchestration docs (PrefectHQ#8660) Allow more ports Bump @playwright/test from 1.30.0 to 1.31.1 in /ui (PrefectHQ#8663) Bump @prefecthq/prefect-ui-library from 1.1.9 to 1.1.10 in /ui (PrefectHQ#8661) Bump vite from 4.1.2 to 4.1.4 in /ui (PrefectHQ#8662) Bump eslint from 8.34.0 to 8.35.0 in /ui (PrefectHQ#8664) Fix of a typo - removed repeated word (PrefectHQ#8654) Enable DefaultAzureCredential authentication for Azure filesystem block (PrefectHQ#7513) Improve supervisor repr for debugging (PrefectHQ#8633) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following best practice for performance, this PR changes SQLA lazy-loads from "joined" to "selectin". Joined loads can be better, especially for many-to-one relationships, but they rewrite the query in ways that can have performance implications for Prefect's typical use patterns. Selectin shows significant performances gains. See also https://github.com/PrefectHQ/nebula/pull/3840 and https://github.com/PrefectHQ/nebula/pull/3842.