Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes migration logic #8255

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Removes migration logic #8255

merged 2 commits into from
Jan 25, 2023

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jan 25, 2023

For safety we will implement migration to work pool queues via extension of the current work queue table. This PR removes the migration logic introduced in #8214 which will not be needed.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit d1b07e8
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/63d1921033bd5a000857d9f1
😎 Deploy Preview https://deploy-preview-8255--prefect-orion.netlify.app/api-ref/orion/models/deployments
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@desertaxle desertaxle marked this pull request as ready for review January 25, 2023 20:55
@desertaxle desertaxle requested review from a team and zangell44 as code owners January 25, 2023 20:55
@desertaxle desertaxle merged commit 04fe311 into main Jan 25, 2023
@desertaxle desertaxle deleted the remove-work-pool-migration branch January 25, 2023 21:01
@peytonrunyan peytonrunyan mentioned this pull request Jan 25, 2023
3 tasks
ddelange added a commit to ddelange/prefect that referenced this pull request Jan 26, 2023
…erm-testing

* 'main' of https://github.com/prefecthq/prefect: (77 commits)
  Update roles and permissions in documentation (PrefectHQ#8263)
  Add Prefect Cloud Quickstart tutorial (PrefectHQ#8227)
  Remove needless log
  Update comment for consistency
  Reorder migrations for clarity
  Refactor cancellation cleanup service
  Uses canonical `CANCELLING` states for run cancellations (PrefectHQ#8245)
  Add cancellation cleanup service (PrefectHQ#8128)
  Improve engine shutdown handling of SIGTERM (PrefectHQ#8127)
  Create a `CANCELLING` state type (PrefectHQ#7794)
  Update KubernetesJob options (PrefectHQ#8261)
  Small work pools UI updates (PrefectHQ#8257)
  Removes migration logic (PrefectHQ#8255)
  Consolidate multi-arch docker builds (PrefectHQ#7902)
  Include nested `pydantic.BaseModel` secret fields in blocks' schema (PrefectHQ#8246)
  Improve contributing documentation with venv instructions (PrefectHQ#8247)
  Update Python tests to use a single test matrix for both databases (PrefectHQ#8171)
  Adds migration logic for work pools (PrefectHQ#8214)
  Add `project_urls` to `setup.py` (PrefectHQ#8224)
  Add `is_schedule_active` to client `Deployment` class (PrefectHQ#7430)
  ...
github-actions bot pushed a commit that referenced this pull request Jan 26, 2023
github-actions bot pushed a commit that referenced this pull request Jan 26, 2023
@zanieb zanieb mentioned this pull request Feb 3, 2023
3 tasks
zanieb pushed a commit that referenced this pull request Feb 3, 2023
zanieb pushed a commit that referenced this pull request Feb 3, 2023
zanieb pushed a commit that referenced this pull request Feb 6, 2023
zanieb pushed a commit that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants