Enhancement: Add an extra info modal component #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhen0
requested review from
pleek91,
stackoverfloweth,
marichka-offen,
znicholasbrown,
brandonreid,
space-age-pete and
nicolascribbles
as code owners
✅ Deploy Preview for orion-design ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for orion-design ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
brandonreid
approved these changes
Feb 1, 2023
| @@ -0,0 +1,34 @@ | |||
| <template> | |||
| <button v-bind="attrs" type="button" @click.stop.prevent="show = true"> | |||
| <p-icon icon="QuestionMarkCircleIcon" solid /> | |||
There was a problem hiding this comment.
A little padding would let the text and ? icon breath, maybe just a pl-1 or pl-2 class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the code form the RBAC info modal to create a general extra info modal component. To be used in https://github.com/PrefectHQ/prefect/pull/8295 and https://github.com/PrefectHQ/nebula-ui/pull/2308