Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add missing content_type kwarg #47

Merged
merged 8 commits into from
Sep 7, 2022
Merged

Add missing content_type kwarg #47

merged 8 commits into from
Sep 7, 2022

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Sep 6, 2022

Summary

Adds content_type to cloud_storage_upload_blob_from_file.

It's placed in the middle of the existing kwargs to match cloud_storage_upload_blob_from_string ordering.

Not sure if I should additionally add **upload_kwargs for other keywords missing?

Relevant Issue(s)

Closes #46

Checklist

@ahuang11 ahuang11 marked this pull request as ready for review September 6, 2022 22:08
@ahuang11 ahuang11 requested a review from desertaxle as a code owner September 6, 2022 22:08
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it'd be worth while to add **kwargs to allow users to use other args that are offered. Also, this might be a good change to switch to using run_sync_in_worker_thread.

@ahuang11
Copy link
Contributor Author

ahuang11 commented Sep 7, 2022

I have the run_sync_in_worker_thread in another incoming PR:
#41

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add **upload_kwargs to catch other arguments that we haven't specifically called out?

prefect_gcp/cloud_storage.py Outdated Show resolved Hide resolved
@ahuang11 ahuang11 requested a review from desertaxle September 7, 2022 16:30
@desertaxle desertaxle merged commit 9788b5b into main Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept other kwargs for file upload task
2 participants