Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix gcp credentials with dbt #44

Merged
merged 8 commits into from
Sep 6, 2022
Merged

Fix gcp credentials with dbt #44

merged 8 commits into from
Sep 6, 2022

Conversation

ahuang11
Copy link
Contributor

Summary

Relevant Issue(s)

Closes #43

Checklist

@ahuang11
Copy link
Contributor Author

ahuang11 commented Aug 26, 2022 •
edited
Loading

Having the type annotation be Dict[str, str] first actually does validation in the UI

image
image

@ahuang11 ahuang11 marked this pull request as ready for review August 26, 2022 18:04
@ahuang11 ahuang11 requested a review from desertaxle as a code owner August 26, 2022 18:04
@ahuang11 ahuang11 mentioned this pull request Aug 26, 2022
Closed
ahuang11
ahuang11 commented Aug 26, 2022
View reviewed changes
tests/test_credentials.py Outdated Show resolved Hide resolved
desertaxle
desertaxle approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this to fix this error, but I'm not sure how this will work with the UI after the refactor. We'll need to keep an eye out for this interaction once the refactor is complete.

@ahuang11 ahuang11 merged commit 564dccd into main Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desertaxle desertaxle desertaxle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: trigger_dbt_cli_command for BigQuery target fails, if credentials are provided with service_account_info
2 participants
@ahuang11 @desertaxle