Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add service_account_name to Cloud Run V2 default template and variables #231

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

kevingrismore
Copy link
Contributor

Adds support for the serviceAccount field in the Cloud Run V2 API Job template via the service_account_name variable to improve default template parity with the V1 work pool.

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@kevingrismore kevingrismore requested a review from a team as a code owner December 3, 2023 17:07
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kevingrismore ! just one comment

Copy link
Contributor

@jakekaplan jakekaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Was just looking for this 😅

@kevingrismore kevingrismore merged commit 4229eda into main Dec 13, 2023
@kevingrismore kevingrismore deleted the add-service-account-template-variable branch December 13, 2023 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants