Chore: Update PSelectOptions to handle its own selection logic #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleek91
requested review from
znicholasbrown,
zhen0 and
brandonreid
as code owners
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pleek91
commented
Dec 6, 2023
Comment on lines
+133
to
+136
| if (multiple.value) { | ||
| return props.modelValue ?? [] | ||
| } | ||
|
|
There was a problem hiding this comment.
small bugfix. Noticed this component wasn't working correctly with modelValue: null | undefined and multiple: true
znicholasbrown
approved these changes
Dec 6, 2023
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small refactor so that PSelectOptions can be used on its own without reproducing all of the logic for highlighting and selecting values.