Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

'Update the pin on prefect version' #160

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Conversation

urimandujano
Copy link
Contributor

As part of our work adding support for Pydantic 2, we removed its pin in
prefect's requirements.txt. This means that it's possible to have
prefect, pydantic>=2, and any version of this collection installed. But,
the collection(s) only support pydantic>=2 in their latest versions. This
PR adds a pin on the collection's requirements.txt to make sure that it is
only installed with the correct version prefect that supports pydantic>=2

@urimandujano urimandujano requested a review from a team as a code owner October 30, 2023 20:40
requirements.txt Outdated
Comment on lines 1 to 3
prefect>=2.7.2
prefect>=2.13.5
dbt_core>=1.1.1
prefect_shell>=0.1.0
prefect>=2.13.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@urimandujano Something got a little weird here, perhaps because there were two dependencies starting with prefect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AH yup -- I'll fix this one manually. Good eye!

@urimandujano urimandujano merged commit a67e7b7 into main Oct 31, 2023
6 checks passed
@urimandujano urimandujano deleted the ft/update-prefect-pin branch October 31, 2023 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants