simplify registry flow #456
Conversation
zzstoatzz
force-pushed
the
revamp-registry-flow
branch
2 times, most recently
from
f9584c7 to
b6fa7dc
Compare
zzstoatzz
force-pushed
the
revamp-registry-flow
branch
from
b6fa7dc to
a6e4031
Compare
zzstoatzz
force-pushed
the
revamp-registry-flow
branch
from
ecd9764 to
3463c2f
Compare
| "secret-str", | ||
| "secret-int", | ||
| "secret-dict", | ||
| "secret-list", | ||
| "secret-float", |
There was a problem hiding this comment.
TODO: handle this case in Block where we have something like Secret[str]
| name: JSON Schema Validation | ||
| entry: uv run src/prefect_collection_registry/view_schema_validation.py | ||
| language: system | ||
| pass_filenames: false | ||
| types: [json] |
There was a problem hiding this comment.
run JSON schema validation as a pre-commit hook
zzstoatzz
force-pushed
the
revamp-registry-flow
branch
2 times, most recently
from
171ed88 to
e6d9b0b
Compare
add note push code update entrypoint whoops subprocess needs it too
zzstoatzz
force-pushed
the
revamp-registry-flow
branch
from
9fb5ce4 to
c13ff5d
Compare
There was a problem hiding this comment.
Is this necessary now that schema validation is a pre-commit hook?
There was a problem hiding this comment.
i think so yes bc there's no guarantee someone installs the pre-commit
|
|
||
|
|
||
| image: prefecthq/prefect:3.1.11-python3.12 | ||
| command: uv run --with git+https://github.com/PrefectHQ/prefect-collection-registry.git@main python -m prefect.engine |
There was a problem hiding this comment.
Why are you overriding the command here?
There was a problem hiding this comment.
to install the dependencies for the flow, putting uv sync in a pull step wasn't working for some reason I'd like to figure out later
| response = await client.get( | ||
| url=f"https://api.github.com/repos/{repo_owner}/{repo_name}/contents/{path}", | ||
| headers={"Accept": "application/vnd.github+json"}, | ||
| ) |
There was a problem hiding this comment.
Seems like you have a lot of different ways to get files from GitHub.
There was a problem hiding this comment.
yes one of them was a duplicate, thanks for catching that, but the other 2 serve different purposes
effectively closes #323
most of the diff is the
uv.lockfilethis pr:
github3dependencyrun_deploymentto spin up separate infra for specific collections and instead justuv runthe subflow (that handles a single collection) in a subprocessprefectcore by moving it all into python