Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Change prefect.docker import to prefect.utilities.dockerutils #273

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

neumann-nico
Copy link
Contributor

@neumann-nico neumann-nico commented May 26, 2023

Change deprecated prefect.docker import to new prefect.utilities.dockerutils import.
Previous import lead to a bug that crashed when trying to import custom blocks based on the S3Block.
This only happens with the latest prefect 2.10.11 update. More information can be found in the issue.

This might require a bump of the minimum prefect version?

Closes
PrefectHQ/prefect#9754

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@neumann-nico
Copy link
Contributor Author

@madkinsz @desertaxle Any chance to get a review?
Thanks a lot!

Copy link
Contributor

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump the minimum core library version too. Thanks!

@desertaxle desertaxle merged commit 9871f3a into PrefectHQ:main Jun 2, 2023
@neumann-nico neumann-nico deleted the fix-docker-import branch June 2, 2023 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants