Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Removes deprecated attributes from S3Bucket #231

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Apr 4, 2023

Removes the following deprecated attributes from the S3Bucket block:

  • basepath
  • aws_crednetials
  • minio_credentials

Adds a basepath property in order to maintain compatibility with storage block based deployments.

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@desertaxle desertaxle marked this pull request as ready for review April 6, 2023 12:16
@desertaxle desertaxle requested review from a team and zzstoatzz April 6, 2023 12:16
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@desertaxle desertaxle merged commit 9e92438 into main Apr 6, 2023
@desertaxle desertaxle deleted the remove-deprecated branch April 6, 2023 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants