Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fixes crashes when pausing flow runs executed with ECSTask #218

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Fixes crashes when pausing flow runs executed with ECSTask #218

merged 2 commits into from
Mar 13, 2023

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Mar 13, 2023 •
edited
Loading

Closes #206

When a flow running on ECS is paused, the flow is marked as crashed because a -1 status code is returned by ECSTask.run. A -1 also appears to be returned on completed flow runs, but the flow is not marked as crashed because it's not possible to transition from a Completed state to a Crashed state.

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@desertaxle desertaxle added the fix label Mar 13, 2023
@desertaxle desertaxle requested a review from a team March 13, 2023 14:09
@desertaxle desertaxle changed the title Allows the return of exit code 0 Allows the return of exit code 0 from ECSTask.run Mar 13, 2023
@desertaxle desertaxle changed the title Allows the return of exit code 0 from ECSTask.run Fixes crashes when pausing flow runs executed with ECSTask Mar 13, 2023
@desertaxle desertaxle requested a review from zanieb March 13, 2023 14:15
@desertaxle desertaxle mentioned this pull request Mar 13, 2023
Closed
zanieb
zanieb approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️

@desertaxle desertaxle merged commit ad3c3ed into main Mar 13, 2023
@desertaxle desertaxle deleted the fix-exit-code branch March 13, 2023 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flows Using ECS Task infrastructure block crash when paused if using reschedule=True
2 participants
@desertaxle @zanieb