This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Respect image from task_definition_arn
and use default prefect image if no image is provided
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuang11
commented
Dec 6, 2022
desertaxle
suggested changes
Dec 6, 2022
…_image into parameterize
desertaxle
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…efect-aws into new_default_for_image_2
ahuang11
commented
Dec 6, 2022
task_definition_arn
and use default prefect image if no image is provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #168 with updates from review because I didn't want to manually remove all the image added in the test.
Sets
image = Field(default=None)
instead ofimage = Field(default_factory=get_prefect_image_name)
Checks if the input values contain an image or a task definition ARN. If either of those are present, it returns those. If neither are present, it checks the task definition for a Prefect container image and uses that if it is present. If no Prefect container image is found, it uses the default Prefect base image.
Closes #138
Example
Screenshots
Checklist
pre-commit
checks.pre-commit install && pre-commit run --all
locally for formatting and linting.mkdocs serve
view documentation locally.